Replace the commentjson test dependency with re.sub #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotmax23
reviewed
Nov 8, 2023
While at it, only open the json files once. Co-authored-by: Maxwell G <maxwell@gtmx.me>
pradyunsg
approved these changes
Dec 9, 2023
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
uranusjr
approved these changes
Apr 3, 2024
uranusjr
reviewed
Apr 3, 2024
|
Thanks everyone! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While at it, only open the json files once.
(This is motivated by Fedora, when we don't have commentjson packaged. Currently, we use json5 instead, but while looking at that @yselkowitz figured out we can pre-process the files instead.)